Unify model input for ByteTokensDocumentModel (#1274)

Summary:
Pull Request resolved: #1274

https://fb.workplace.com/groups/300451907202972/permalink/589822794932547/

Reviewed By: codekansas

Differential Revision: D20367268

fbshipit-source-id: 8f5c7af1b8ff8247cdf1d1c0949aa2ab1620752b

pytext/models/doc_model.py

@@ -153,14 +153,13 @@ def forward(
             ):
                 if tokens is None:
                     raise RuntimeError("tokens is required")
+                if dense_feat is None:
+                    raise RuntimeError("dense_feat is required")
 
                 seq_lens = make_sequence_lengths(tokens)
                 word_ids = self.vocab.lookup_indices_2d(tokens)
                 word_ids = pad_2d(word_ids, seq_lens, self.pad_idx)
-                if dense_feat is not None:
-                    dense_feat = self.normalizer.normalize(dense_feat)
-                else:
-                    raise RuntimeError("dense is required")
+                dense_feat = self.normalizer.normalize(dense_feat)
                 logits = self.model(
                     torch.tensor(word_ids),
                     torch.tensor(seq_lens),
@@ -281,7 +280,14 @@ def __init__(self):
                 self.output_layer = output_layer
 
             @jit.script_method
-            def forward(self, tokens: List[List[str]]):
+            def forward(
+                self,
+                texts: Optional[List[str]] = None,
+                tokens: Optional[List[List[str]]] = None,
+                languages: Optional[List[str]] = None,
+            ):
+                if tokens is None:
+                    raise RuntimeError("tokens is required")
                 seq_lens = make_sequence_lengths(tokens)
                 word_ids = self.vocab.lookup_indices_2d(tokens)
                 word_ids = pad_2d(word_ids, seq_lens, self.pad_idx)
@@ -307,7 +313,18 @@ def __init__(self):
                 self.output_layer = output_layer
 
             @jit.script_method
-            def forward(self, tokens: List[List[str]], dense_feat: List[List[float]]):
+            def forward(
+                self,
+                texts: Optional[List[str]] = None,
+                tokens: Optional[List[List[str]]] = None,
+                languages: Optional[List[str]] = None,
+                dense_feat: Optional[List[List[float]]] = None,
+            ):
+                if tokens is None:
+                    raise RuntimeError("tokens is required")
+                if dense_feat is None:
+                    raise RuntimeError("dense_feat is required")
+
                 seq_lens = make_sequence_lengths(tokens)
                 word_ids = self.vocab.lookup_indices_2d(tokens)
                 word_ids = pad_2d(word_ids, seq_lens, self.pad_idx)