This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
changes to make tutorial code simpler #1002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebookresearch#979 D17241503 selects only masked tokens for the final logits / targets during MLM. This fails when there are no masked tokens (e.g. at the end of a file there can be a very short batch). In this case, select just the first token in the first batch. BTW, the new masking strategy is faster (20%) than the old one - f138005051 vs f138005044. Differential Revision: D17370855 fbshipit-source-id: 453ccc4797c0d976281aa14212eba43b6f9b5d6f
Summary: create lang2id maps for 15,20,and 43 that can be imported define the read_vocab helper functions outside the tensorize to be used in notebook tutorial Reviewed By: kartikayk Differential Revision: D17555133 fbshipit-source-id: 2d00fa2357959d58a2511302377feeb7f376cf01
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in d6e9b14. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
create lang2id maps for 15,20,and 43 that can be imported
define the read_vocab helper functions outside the tensorize to be used in notebook tutorial
Reviewed By: kartikayk
Differential Revision: D17555133