This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Implement Blockwise Sparsification #1050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D17910541 |
psuzhanhy
added a commit
to psuzhanhy/pytext
that referenced
this pull request
Oct 15, 2019
Summary: Pull Request resolved: facebookresearch#1050 Support row or column blockwise sparsification. Group parameters into blocks and either an entire block is removed or retained. 1. refactor sparsifier.py under optimizer/sparsifers and create "sparsifiers_lib". Reason: some sparsifiers depend on "models_lib" to extract particualr layers to perform sparsification. Yet "models_lib depends on "optimizers_lib". Refactoring prevents circular dependency. 2. add blockwise_sparsifier.py and unit-tests. Differential Revision: D17910541 fbshipit-source-id: 81a35ed6de6ff5f97366cbb0a231424e9a7b0579
psuzhanhy
force-pushed
the
export-D17910541
branch
from
9ff4bda
to
322d8e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17910541 |
psuzhanhy
added a commit
to psuzhanhy/pytext
that referenced
this pull request
Oct 15, 2019
Summary: Pull Request resolved: facebookresearch#1050 Support row or column blockwise sparsification. Group parameters into blocks and either an entire block is removed or retained. 1. refactor sparsifier.py under optimizer/sparsifers and create "sparsifiers_lib". Reason: some sparsifiers depend on "models_lib" to extract particualr layers to perform sparsification. Yet "models_lib depends on "optimizers_lib". Refactoring prevents circular dependency. 2. add blockwise_sparsifier.py and unit-tests. Differential Revision: D17910541 fbshipit-source-id: 1721ca8f324a8ff03c53b162b726133f3f1c22a6
psuzhanhy
force-pushed
the
export-D17910541
branch
from
322d8e5
to
440bee9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17910541 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D17910541 |
psuzhanhy
force-pushed
the
export-D17910541
branch
from
440bee9
to
8996632
Compare
psuzhanhy
added a commit
to psuzhanhy/pytext
that referenced
this pull request
Oct 21, 2019
Summary: Pull Request resolved: facebookresearch#1050 Support row or column blockwise sparsification. Group parameters into blocks and either an entire block is removed or retained. 1. refactor sparsifier.py under optimizer/sparsifers and create "sparsifiers_lib". Reason: some sparsifiers depend on "models_lib" to extract particualr layers to perform sparsification. Yet "models_lib depends on "optimizers_lib". Refactoring prevents circular dependency. 2. add blockwise_sparsifier.py and unit-tests. Differential Revision: D17910541 fbshipit-source-id: 841e36e1ab3699e6606e89240e7797e4e1ea0544
psuzhanhy
added a commit
to psuzhanhy/pytext
that referenced
this pull request
Oct 21, 2019
Summary: Pull Request resolved: facebookresearch#1050 Support row or column blockwise sparsification. Group parameters into blocks and either an entire block is removed or retained. 1. refactor sparsifier.py under optimizer/sparsifers and create "sparsifiers_lib". Reason: some sparsifiers depend on "models_lib" to extract particualr layers to perform sparsification. Yet "models_lib depends on "optimizers_lib". Refactoring prevents circular dependency. 2. add blockwise_sparsifier.py and unit-tests. Differential Revision: D17910541 fbshipit-source-id: a86b53d70aebbca7fa4eb12aeada5d5b4297fb38
psuzhanhy
force-pushed
the
export-D17910541
branch
from
8996632
to
84651ce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17910541 |
Summary: Pull Request resolved: facebookresearch#1050 Support row or column blockwise sparsification. Group parameters into blocks and either an entire block is removed or retained. 1. refactor sparsifier.py under optimizer/sparsifers and create "sparsifiers_lib". Reason: some sparsifiers depend on "models_lib" to extract particualr layers to perform sparsification. Yet "models_lib depends on "optimizers_lib". Refactoring prevents circular dependency. 2. add blockwise_sparsifier.py and unit-tests. Reviewed By: arbabu123 Differential Revision: D17910541 fbshipit-source-id: 7451beac9f974d7fa52595339438b73259f3139d
psuzhanhy
force-pushed
the
export-D17910541
branch
from
84651ce
to
745b4b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D17910541 |
|
This pull request has been merged in 0e6132c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support row or column blockwise sparsification. Group parameters into blocks and either an entire block is removed or retained.
refactor sparsifier.py under optimizer/sparsifers and create "sparsifiers_lib". Reason: some sparsifiers depend on "models_lib" to extract particualr layers to perform sparsification. Yet "models_lib depends on "optimizers_lib". Refactoring prevents circular dependency.
add blockwise_sparsifier.py and unit-tests.
Differential Revision: D17910541