This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fp16 fixes for byte-lstm and distillation #1059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fixes: - sequence dimension of bytes for byte-lstm was set outside of `precision`; instead determine the dimension using `precision`. - class dimension of soft labels was determined by `pad` which depends on precision; instead always keep it the number of classes (just like for hard labels and model logits). Reviewed By: chenyangyu1988 Differential Revision: D17967471 fbshipit-source-id: 65748c3eedb79c525684930911bcc69a25bc00b3
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D17967471 |
|
This pull request has been merged in 90c9c2c. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fixes:
sequence dimension of bytes for byte-lstm was set outside of
precision; instead determine the dimension usingprecision.class dimension of soft labels was determined by
padwhich depends on precision; instead always keep it the number of classes (just like for hard labels and model logits).Reviewed By: chenyangyu1988
Differential Revision: D17967471