This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix unk bug in exported model #1076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18129567 |
Summary: Pull Request resolved: facebookresearch#1076 previously vocab unk index for torchscripted XLM model, wasn't set, thus was using the default 0, while for training we were using 3. Fixed, and also added a unit test to allow catching such issues Reviewed By: mwu1993 Differential Revision: D18129567 fbshipit-source-id: 544bffeef51128bc8b6c425f54d5a3f7a26e9824
rutyrinott
force-pushed
the
export-D18129567
branch
from
6b14a36
to
95faea6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18129567 |
|
This pull request has been merged in 79eeb51. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
previously vocab unk index for torchscripted XLM model, wasn't set, thus was using the default 0, while for training we were using 3.
Fixed, and also added a unit test to allow catching such issues
Differential Revision: D18129567