This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix label_weights in DocModel #1081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18176357 |
Summary: Pull Request resolved: facebookresearch#1081 While playing around with the label_weights for OOD found a bug in the way the loss is constructed for the DocModel class resulting in the label_weights not being passed to the loss constructor. Verified in a bento that the trained model had empty label_weights in the loss. This fixes the bug and properly passes the weights to the constructor Differential Revision: D18176357 fbshipit-source-id: ed2bfd986566db696903d458513d63445863e5d9
anchit
force-pushed
the
export-D18176357
branch
from
87ec7d3
to
67e0d37
Compare
anchit
added a commit
to anchit/pytext
that referenced
this pull request
Oct 30, 2019
Summary: Pull Request resolved: facebookresearch#1081 While playing around with the label_weights for OOD found a bug in the way the loss is constructed for the DocModel class resulting in the label_weights not being passed to the loss constructor. Verified in a bento that the trained model had empty label_weights in the loss. This fixes the bug and properly passes the weights to the constructor Differential Revision: D18176357 fbshipit-source-id: 238d04db7bca7d245309364a6449c115358499ea
|
This pull request was exported from Phabricator. Differential Revision: D18176357 |
anchit
force-pushed
the
export-D18176357
branch
from
67e0d37
to
45dde8a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18176357 |
|
This pull request has been merged in 3b74ab3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: While playing around with the label_weights for OOD found a bug in the way the loss is constructed for the DocModel class resulting in the label_weights not being passed to the loss constructor. Verified in a bento that the trained model had empty label_weights in the loss. This fixes the bug and properly passes the weights to the constructor
Differential Revision: D18176357