This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix Heirarchical intent and slot filling demo is broken (#1012) #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch#1012) In daae0c3, the column_schema for AnnotationNumberizer changed from str to List[str], which led to the broken demo
facebook-github-bot
added
the
CLA Signed
|
I was able to train a hierarchical intent and slot filling model using this fix. Thanks! |
There was a problem hiding this comment.
@mwu1993 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In daae0c3, the column_schema for
AnnotationNumberizer changed from str to List[str], which led to the
broken demo
Motivation and Context
Fixes #1012
How Has This Been Tested
Types of changes
Checklist