This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Proper behavior for do_eval=False #1155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In trainer, the option `do_eval` (https://fburl.com/diffusion/lopy7hig) can be set to `False` to skip eval stage in training. However, the eval stage is always run in the finalize step (see changes in this diff). This can cause issues when eval data is not provided, see the failed workflow for example: f151938461 In this diff, if `do_eval` is set to `False`, we also skip the eval operation in the finalize step. Differential Revision: D18590815 fbshipit-source-id: 7041e95e709cfa3873db6f165a76a4d0d0160d87
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18590815 |
|
This pull request has been merged in 99e3669. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In trainer, the option
do_eval(https://fburl.com/diffusion/lopy7hig) can be set toFalseto skip eval stage in training. However, the eval stage is always run in the finalize step (see changes in this diff). This can cause issues when eval data is not provided, see the failed workflow for example:f151938461
In this diff, if
do_evalis set toFalse, we also skip the eval operation in the finalize step.Differential Revision: D18590815