This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Allow null learning rate #1156
Closed
Allow null learning rate #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18626943 |
AkshatSh
pushed a commit
to AkshatSh/pytext
that referenced
this pull request
Nov 20, 2019
Summary: Pull Request resolved: facebookresearch#1156 While the code itself handles the null case for `swa_lr` the config doesn't allow it. This fixes that. Reviewed By: ArmenAg Differential Revision: D18626943 fbshipit-source-id: 5b4d5e6cf9314fe77940f662876897a518cece45
AkshatSh
force-pushed
the
export-D18626943
branch
from
bc83340
to
89aa369
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18626943 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D18626943 |
AkshatSh
force-pushed
the
export-D18626943
branch
from
89aa369
to
da7e96e
Compare
AkshatSh
pushed a commit
to AkshatSh/pytext
that referenced
this pull request
Nov 25, 2019
Summary: Pull Request resolved: facebookresearch#1156 While the code itself handles the null case for `swa_lr` the config doesn't allow it. This fixes that. Reviewed By: ArmenAg Differential Revision: D18626943 fbshipit-source-id: 32e9b94b3cdfab26062aa56e3709a4372f658bf9
Summary: Pull Request resolved: facebookresearch#1156 While the code itself handles the null case for `swa_lr` the config doesn't allow it. This fixes that. Reviewed By: ArmenAg Differential Revision: D18626943 fbshipit-source-id: 05b98975b7d5e00bab29c06232dd751aae543ee6
AkshatSh
force-pushed
the
export-D18626943
branch
from
da7e96e
to
3dfb5fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18626943 |
|
This pull request has been merged in e261466. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: While the code itself handles the null case for
swa_lrthe config doesn't allow it. This fixes that.Reviewed By: ArmenAg
Differential Revision: D18626943