This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Use PathManager for all I/O #1198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D19085748 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 17, 2019
Summary: Pull Request resolved: facebookresearch#1198 Any I/O API X (open, exists, isfile, etc) need to use "PathManager.X()", such that either file, manifold uri, http uri, etc can be supported in PyText without any code changes(handle for each storage type) Differential Revision: D19085748 fbshipit-source-id: 841b0cf7a37805016e6ce2cfb771ea1f38cdbbb1
hudeven
force-pushed
the
export-D19085748
branch
from
5a174dd
to
dfdce50
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19085748 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 18, 2019
Summary: Pull Request resolved: facebookresearch#1198 Any I/O API X (open, exists, isfile, etc) need to use "PathManager.X()", such that either file, manifold uri, http uri, etc can be supported in PyText without any code changes(handle for each storage type) Reviewed By: chenyangyu1988 Differential Revision: D19085748 fbshipit-source-id: c0d4537da88df3ddfbf1f4cc5587fdc36c35e6ea
hudeven
force-pushed
the
export-D19085748
branch
from
dfdce50
to
35aeefc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19085748 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 18, 2019
Summary: Pull Request resolved: facebookresearch#1198 Any I/O API X (open, exists, isfile, etc) need to use "PathManager.X()", such that either file, manifold uri, http uri, etc can be supported in PyText without any code changes(handle for each storage type) Reviewed By: chenyangyu1988 Differential Revision: D19085748 fbshipit-source-id: 956566f801ae9106f5d5917b36295aff771107e4
hudeven
force-pushed
the
export-D19085748
branch
from
35aeefc
to
4552709
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19085748 |
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Dec 18, 2019
Summary: Pull Request resolved: facebookresearch#1198 Any I/O API X (open, exists, isfile, etc) need to use "PathManager.X()", such that either file, manifold uri, http uri, etc can be supported in PyText without any code changes(handle for each storage type) Reviewed By: chenyangyu1988 Differential Revision: D19085748 fbshipit-source-id: 81805bd12c6808c23821340d0cc364bfae5cd5e4
hudeven
force-pushed
the
export-D19085748
branch
from
4552709
to
15a25cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19085748 |
Differential Revision: D18803124 fbshipit-source-id: 10f1a9837c2d820db0278eaae8fefe26e0a427ee
Summary: Pull Request resolved: facebookresearch#1198 Any I/O API X (open, exists, isfile, etc) need to use "PathManager.X()", such that either file, manifold uri, http uri, etc can be supported in PyText without any code changes(handle for each storage type) Reviewed By: chenyangyu1988 Differential Revision: D19085748 fbshipit-source-id: 46235e3c9dc8798f16f763dbcf3a583233e0d1a6
hudeven
force-pushed
the
export-D19085748
branch
from
15a25cc
to
1e2ce32
Compare
|
This pull request was exported from Phabricator. Differential Revision: D19085748 |
|
This pull request has been merged in 7ac6144. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Any I/O API X (open, exists, isfile, etc) need to use "PathManager.X()", such that either file, manifold uri, http uri, etc can be supported in PyText without any code changes(handle for each storage type)
Differential Revision: D19085748