Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

tidy file path in help text for invocation of docnn.json example #1221

Closed
wants to merge 1 commit into from

Conversation

mgoldey
Copy link
Contributor

@mgoldey mgoldey commented Jan 7, 2020

Motivation and Context

Help text in docs and for pytext executable had an incorrect file path for the example config file.

How Has This Been Tested

Tested via docker

docker run --rm -it --gpus all --entrypoint=/bin/bash --net host pytorch/pytorch:1.3-cuda10.1-cudnn7-runtime

export LC_ALL=C.UTF-8
export LANG=C.UTF-8

apt update && \
  apt install -y cmake protobuf-compiler libprotoc-dev ssh

git clone http://github.com/mgoldey/pytext.git

cd pytext
git checkout mgoldey/FixHelpText

source activation_venv && \
pip install torch pytest && \
./install_deps && \
python3 setup.py build && \
python3 setup.py install && \
python3 setup.py test

Output

----------------------------------------------------------------------
Ran 81 tests in 5.945s

OK

I've confirmed in that docker container that pytext --help gives

    pytext train < demo/configs/docnn.json

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
    Enforced via black and isort invocations per CONTRIBUTING.md
  • My change requires a change to the documentation.
    This is a change to the documentation
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
    - [ ] I have added tests to cover my changes. N/A
    - [ ] All new and existing tests passed. N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 7, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rutyrinott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@rutyrinott merged this pull request in 03b5779.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants