This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Vocab recursive lookup #1222
Closed
Vocab recursive lookup #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The previous logic is harder to understand and introduce unnecessary if/else condition, this diff target to simplify and make it easy recurisve function. Differential Revision: D19303258 fbshipit-source-id: 4bfd945747a96735cdaf0c6a24750c790b58082c
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D19303258 |
|
This pull request has been merged in 7d9c36b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The previous logic is harder to understand and introduce unnecessary if/else condition, this diff target to simplify and make it easy recurisve function.
Differential Revision: D19303258