This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Add class logging to task #1264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20038656 |
Summary: This adds usage logging on some data classes. I didn't try to cover everything, but stuck to high leverage (Tensorizer and data), interesting (all the tokenizers) or things we want to kill (old data_handler) Differential Revision: D20005195 fbshipit-source-id: b8f92bc9594b7f4f5618881801ccf384e8fcf87a
Summary: added `log_class_usage` to every class that looked interesting and already had an `__init__` function. This should allow us to track which model components are actually in use. Differential Revision: D20037495 fbshipit-source-id: 07e27dd64a8e1a8dc2ae4d27ae50b9ec99351c7c
Summary: This will let us track usage of onnx export Differential Revision: D20038166 fbshipit-source-id: 110b711ae9e9d38ae9cd55ab8ccd8585e41dba4e
Summary: Pull Request resolved: facebookresearch#1264 This should catch most PyText usage and also let us catch usage of the old task abstraction Reviewed By: hudeven Differential Revision: D20038656 fbshipit-source-id: 4d8f29d8246b821e1515f7175c6cf439c670368e
m3rlin45
force-pushed
the
export-D20038656
branch
from
3a71e67
to
7262785
Compare
|
This pull request was exported from Phabricator. Differential Revision: D20038656 |
|
This pull request has been merged in 7050626. |
|
This pull request has been merged in 7050626. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This should catch most PyText usage and also let us catch usage of the old task abstraction
Differential Revision: D20038656