This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix contiguous isse in bilstm export #1270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch#1269) Summary: Pull Request resolved: facebookresearch#1269 Unlike single LabelTensorizer labels are much more likely missing in a sequence. In this change we add an option in the tensorizer to pad these missing labels. Differential Revision: D20187694 fbshipit-source-id: 5770cdcca12a0427c93495555a5dfe7f85c93685
Summary: Call contiguous function on the input embedding in case it's not contiguous, which will cause issue in the Caffe2 operator Reviewed By: shivanipoddariiith Differential Revision: D20277324 fbshipit-source-id: 3c2bf70f5675a52591822822c36637054e588232
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20277324 |
|
This pull request has been merged in 569d107. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Call contiguous function on the input embedding in case it's not contiguous, which will cause issue in the Caffe2 operator
Reviewed By: shivanipoddariiith
Differential Revision: D20277324