This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Move generator builder to constructor so that it can easily overridden. #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is needed to support other generators eg: non auto regressive Reviewed By: twwhatever Differential Revision: D20543478 fbshipit-source-id: 05e26f3753f19825ef7a07da27ad450d6fd08614
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20543478 |
|
This pull request has been merged in 1a9fa0b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This is needed to support other generators eg: non auto regressive
Reviewed By: twwhatever
Differential Revision: D20543478