This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Avoid edge cases with quantization by setting a known seed #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Stress test reveals some cases where the model returns NaN (https://our.intern.facebook.com/intern/testinfra/diagnostics/3377699742969609.844424947441516.1585199924/). My guess is that some initializations play badly with quantization, so forcing a known seed to try and fix it. Differential Revision: D20673784 fbshipit-source-id: 325e744ebebe916c4d6337a223c2b333a46ce5a0
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D20673784 |
|
This pull request has been merged in 24b68d7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Stress test reveals some cases where the model returns NaN (https://our.intern.facebook.com/intern/testinfra/diagnostics/3377699742969609.844424947441516.1585199924/). My guess is that some initializations play badly with quantization, so forcing a known seed to try and fix it.
Differential Revision: D20673784