This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix Incorrect State Dict Assumption #1326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21100333 |
Summary: Pull Request resolved: facebookresearch#1326 PyText currently assumes that the state_dict is a flat key,value ordered dict where the value is typed as tensor. This is not neccessarily true: https://pytorch.org/tutorials/beginner/saving_loading_models.html#saving-multiple-models-in-one-file This diff fixes this assumption. Differential Revision: D21100333 fbshipit-source-id: 9fb586c2462e48429f7814ab56130b9cc4ff03bb
ArmenAg
force-pushed
the
export-D21100333
branch
from
e5b5714
to
84bf72e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21100333 |
|
This pull request has been merged in 942a49f. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PyText currently assumes that the state_dict is a flat key,value ordered dict where the value is typed as tensor. This is not neccessarily true: https://pytorch.org/tutorials/beginner/saving_loading_models.html#saving-multiple-models-in-one-file
This diff fixes this assumption.
Differential Revision: D21100333