This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Add 'contrib' directory #1333
Closed
Add 'contrib' directory #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added instructions about 'contrib' directory
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@hudeven has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hudeven
added a commit
to hudeven/pytext
that referenced
this pull request
Apr 23, 2020
Summary: ## Motivation and Context We need the 'contrib' directory to hold experimental code, which is accessible in OSS. First 2 use cases: 1) moving HuggingFace transform related code and dependency there 2) maintain prototypes for PyText Library there ## How Has This Been Tested ## Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist - [ ] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [x] I have updated the documentation accordingly. - [ ] I have read the **CONTRIBUTING** document. - [x] I have completed my CLA (see **CONTRIBUTING**) - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. Pull Request resolved: facebookresearch#1333 Differential Revision: D21189667 Pulled By: hudeven fbshipit-source-id: 55b3a2488a3e3bae49b6834f9f442c4c59a2e8a1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We need the 'contrib' directory to hold experimental code, which is accessible in OSS. First 2 use cases: 1) moving HuggingFace transform related code and dependency there 2) maintain prototypes for PyText Library there
How Has This Been Tested
Types of changes
Checklist