This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix RoBERTa Q&A Training Bug with multiple BoS tokens. #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21287576 |
…rch#1343) Summary: Pull Request resolved: facebookresearch#1343 SquadForRoBERTaTensorizer adds two BoS tokens to the input sequence during training and eval which differs from inference time behavior. This diff fixes that bug. Reviewed By: hikushalhere Differential Revision: D21287576 fbshipit-source-id: e1a5ad3b3c621a99e1bbc85035879b2ae31caa28
debowin
force-pushed
the
export-D21287576
branch
from
fde9d33
to
43dd988
Compare
|
This pull request was exported from Phabricator. Differential Revision: D21287576 |
|
This pull request has been merged in 77a32ac. |
alexeib
added a commit
to alexeib/pytext
that referenced
this pull request
Oct 19, 2020
…arch#1343) Summary: this is the main pr that switches on hydra functionality in fairseq we migrate "args" object into omegaconf "DictConfig" at all legacy entry points in addition this migrates various components from secondary registries (like bpe encoders and tokenizers) to make the migration smoother i am going through code that references migrated fairseq components and changing it to inherit from "Legacy*" components instead. hopefully tests will catch most of this Pull Request resolved: fairinternal/fairseq-py#1343 Differential Revision: D23973928 Pulled By: alexeib fbshipit-source-id: e1eb1b59160dacd87640a5d230d5fba027cdb502
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2020
Summary: Pull Request resolved: #1510 this is the main pr that switches on hydra functionality in fairseq we migrate "args" object into omegaconf "DictConfig" at all legacy entry points in addition this migrates various components from secondary registries (like bpe encoders and tokenizers) to make the migration smoother i am going through code that references migrated fairseq components and changing it to inherit from "Legacy*" components instead. hopefully tests will catch most of this Pull Request resolved: fairinternal/fairseq-py#1343 Reviewed By: myleott Differential Revision: D23973928 Pulled By: alexeib fbshipit-source-id: dd9554981fff51ea75c1ff343874d1d6e61793c9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SquadForRoBERTaTensorizer adds two BoS tokens to the input sequence during training and eval which differs from inference time behavior.
This diff fixes that bug.
Differential Revision: D21287576