This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix bug in ClassificationOutputLayer that pad_idx is never respected #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently the pad_idx is not correctly passed to loss function, this commit is to fix this bug Differential Revision: D21366626 fbshipit-source-id: ba5b3c1560ab0de20878f0a261b2a2469da52f6a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21366626 |
|
This pull request has been merged in 27d27b1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently the pad_idx is not correctly passed to loss function, this commit is to fix this bug
Differential Revision: D21366626