Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Add mentioning of mixed precision training support #643

Closed
wants to merge 2 commits into from

Conversation

khoa-ho
Copy link
Contributor

@khoa-ho khoa-ho commented May 30, 2019

Summary: Add documentation to highlight support for mixed precision training (#611)

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 30, 2019
@Titousensei
Copy link
Contributor

Thanks for the PR. Please fix build_docs so we can include it.

@khoa-ho
Copy link
Contributor Author

khoa-ho commented Jul 17, 2019

@Titousensei Thank you for reaching out. I'm not very familiar with build_docs, do you have any hint why it might fail?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Titousensei has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Titousensei
Titousensei previously approved these changes Sep 19, 2019
@Titousensei Titousensei self-requested a review September 19, 2019 22:55
@Titousensei Titousensei dismissed their stale review September 19, 2019 22:55

build_docs still failing.

@Titousensei
Copy link
Contributor

I think build_docs is was broken in master when you submitted your PR. Please try rebasing to the most recent master.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Titousensei has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Highlight the model's support for mixed precision training
@facebook-github-bot
Copy link
Contributor

@khoa-ho has updated the pull request. Re-import the pull request

@khoa-ho
Copy link
Contributor Author

khoa-ho commented Sep 23, 2019

@Titousensei Rebasing to most recent master did get rid of the build_docs error. Please help merge the PR. Thank you!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Titousensei has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Titousensei merged this pull request in 6ea5ce5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants