This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Improve get_logits() #683
Closed
Improve get_logits() #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D15757521 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D15757521 |
…utput tensors (#683) Summary: Pull Request resolved: #683 1. Dump model inputs if configured to do so. This makes preparing the input file for KD easier: an extra step to combine logits file and input file is not required. 2. Check for existence of file in squad.unflatten() and print a message but don't fail. PyText loading has a limitation that for task creation tries to load the train/test/eval files in model config. However, the files may not exist at the time of loading the model. To overcome the limitation adding a check to ignore files that don't exist. The drawback of this is that during model training if the file doesn't exist then the training will not fail but go on. However, if this occurs then the model will not train at all and the metrics should raise a flag. Plus there's a warning message that flags the fact file paths supplied did not exist. Reviewed By: borguz Differential Revision: D15757521 fbshipit-source-id: f1271b10d77e5894581af2781a550a254f1bd4e2
|
This pull request was exported from Phabricator. Differential Revision: D15757521 |
|
This pull request has been merged in d46a90f. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D15757521