This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Combine KLDivergenceBCELoss with SoftHardBCELoss and F.cross_entropy() in CrossEntropyLoss #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…) in CrossEntropyLoss (#689) Summary: Pull Request resolved: #689 1. By virtue of its name `KLDivergenceBCELoss` should take care of BCELoss with hard targets but it doesn't. On the other hand SoftHardBCELoss does exactly that. Combining the two. 2. Using `F.cross_entropy()` in CrossEntropyLoss which is numerically more stable than doing `log_sftmax()` -> `nll_loss()`. Reviewed By: gardenia22 Differential Revision: D15795206 fbshipit-source-id: e358264b17f11b78daf49936b35c6a0b3a958fc6
|
This pull request has been merged in d994b4a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
KLDivergenceBCELossshould take care of BCELoss with hard targets but it doesn't. On the other hand SoftHardBCELoss does exactly that. Combining the two.F.cross_entropy()in CrossEntropyLoss which is numerically more stable than doinglog_sftmax()->nll_loss().Differential Revision: D15795206