This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fixes weight tying bug #704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: facebookresearch#704 Fixes weight tying bug in LM Reviewed By: abhinavarora Differential Revision: D15881237 fbshipit-source-id: 6474c730fb2fba473328b835b3522f5bbadb34d2
shreydesai
force-pushed
the
export-D15881237
branch
from
bdec150
to
eb00070
Compare
|
This pull request has been merged in 98fa4cd. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes weight tying bug in LM
Manually checked -- I see a reduction in trainable parameters
Differential Revision: D15881237