This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix BoundaryPooling tracing #713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Array slicing using the results of a .size() will store the slice index as constant in the trace. In this case we don't even need to tracing to work nicely because we can just record a constant -1 for the slicing. Differential Revision: D15932989 fbshipit-source-id: fd1bd83b65ad5137a13a7501947377277944857d
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in 115ba44. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Array slicing using the results of a .size() will store the slice index as constant in the trace. In this case we don't even need to tracing to work nicely because we can just record a constant -1 for the slicing.
Differential Revision: D15932989