This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix duplicate entries in vocab #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We are overriding the pad token during vocab building which will cause pad token to be inserted twice if pad token is also included in the training data, this diff will ensure that the vocab contains each item uniquely Differential Revision: D15968626 fbshipit-source-id: adc0da40f5cba6690813fc22ac64ab7e766052e1
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in 681e20f. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We are overriding the pad token during vocab building which will cause pad token to be inserted twice if pad token is also included in the training data, this diff will ensure that the vocab contains each item uniquely
Differential Revision: D15968626