This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix intent slot metric reporter not working with byte offset #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
added 2 commits
August 7, 2019 16:57
Differential Revision: D16693643 fbshipit-source-id: 0567dbcd039e69b90a3bd322083b2747a33c2e2f
…kresearch#883) Summary: Pull Request resolved: facebookresearch#883 In PyText, the offsets in slots uses byte offset, but were processed though Python slicing. We make the fix in this diff. Reviewed By: abhinavarora Differential Revision: D16693644 fbshipit-source-id: a9d3557b408b7f68522d37fe7659c7210ee355d3
cyclotomic2
force-pushed
the
export-D16693644
branch
from
a8f8394
to
4da8ebb
Compare
|
This pull request has been merged in a48f820. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In PyText, the offsets in slots uses byte offset, but were processed though Python slicing. We make the fix in this diff.
Reviewed By: abhinavarora
Differential Revision: D16693644