This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Propagate min_freq for vocab correctly #907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: facebookresearch#907 Propogate min_freq to build_vocab. Note, `vocab_size` param does not work, torchtext fields have no support for it. Differential Revision: D16795720 fbshipit-source-id: c3595d4ec3ce1259487c38e136f27b0b2b599df6
litesaber15
force-pushed
the
export-D16795720
branch
from
ba18b17
to
5e6f7ac
Compare
|
This pull request has been merged in 5dacbf1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Propogate min_freq to build_vocab. Note,
vocab_sizeparam does not work, torchtext fields have no support for it.Differential Revision: D16795720