This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
save best model's sub-modules when enabled #912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
neo315
force-pushed
the
export-D16832632
branch
from
0cc1b6e
to
ebd3061
Compare
neo315
pushed a commit
to neo315/pytext
that referenced
this pull request
Aug 15, 2019
Summary: Pull Request resolved: facebookresearch#912 - currently model's sub modules are saved with suffix of "-ep{epoch}", this works well for per-epoch saved sub-modules, if save_all_checkpoints is enabled. But the best final model's sub-moduels has the same naming format that can be confusing. This diff save one additional sub-modules for best model Differential Revision: D16832632 fbshipit-source-id: bbe5f8ed43ce32d9bde051bb73d8bca48671d843
neo315
force-pushed
the
export-D16832632
branch
from
ebd3061
to
d7156b0
Compare
neo315
pushed a commit
to neo315/pytext
that referenced
this pull request
Aug 15, 2019
Summary: Pull Request resolved: facebookresearch#912 - currently model's sub modules are saved with suffix of "-ep{epoch}", this works well for per-epoch saved sub-modules, if save_all_checkpoints is enabled. But the best final model's sub-moduels has the same naming format that can be confusing. This diff save one additional sub-modules for best model Reviewed By: chenyangyu1988 Differential Revision: D16832632 fbshipit-source-id: 2fc6f548ce6abfaf1288f42d91544bbb3b4bb33d
neo315
force-pushed
the
export-D16832632
branch
from
d7156b0
to
d0c3f4d
Compare
neo315
pushed a commit
to neo315/pytext
that referenced
this pull request
Aug 15, 2019
Summary: Pull Request resolved: facebookresearch#912 - currently model's sub modules are saved with suffix of "-ep{epoch}", this works well for per-epoch saved sub-modules, if save_all_checkpoints is enabled. But the best final model's sub-moduels has the same naming format that can be confusing. This diff save one additional sub-modules for best model Reviewed By: chenyangyu1988 Differential Revision: D16832632 fbshipit-source-id: 77e464436be03e210414423b049442ead81c5983
neo315
force-pushed
the
export-D16832632
branch
from
d0c3f4d
to
c2aa505
Compare
neo315
pushed a commit
to neo315/pytext
that referenced
this pull request
Aug 15, 2019
Summary: Pull Request resolved: facebookresearch#912 - currently model's sub modules are saved with suffix of "-ep{epoch}", this works well for per-epoch saved sub-modules, if save_all_checkpoints is enabled. But the best final model's sub-moduels has the same naming format that can be confusing. This diff save one additional sub-modules for best model Reviewed By: chenyangyu1988 Differential Revision: D16832632 fbshipit-source-id: 80ba0045a10e5a819e05c59790fd43f0815c20a1
neo315
force-pushed
the
export-D16832632
branch
from
c2aa505
to
c867a57
Compare
neo315
pushed a commit
to neo315/pytext
that referenced
this pull request
Aug 15, 2019
Summary: Pull Request resolved: facebookresearch#912 - currently model's sub modules are saved with suffix of "-ep{epoch}", this works well for per-epoch saved sub-modules, if save_all_checkpoints is enabled. But the best final model's sub-moduels has the same naming format that can be confusing. This diff save one additional sub-modules for best model Reviewed By: chenyangyu1988 Differential Revision: D16832632 fbshipit-source-id: db6d76a21d8026addec3422d323b0028e420cc08
Summary: Pull Request resolved: facebookresearch#912 - currently model's sub modules are saved with suffix of "-ep{epoch}", this works well for per-epoch saved sub-modules, if save_all_checkpoints is enabled. But the best final model's sub-moduels has the same naming format that can be confusing. This diff save one additional sub-modules for best model Reviewed By: chenyangyu1988 Differential Revision: D16832632 fbshipit-source-id: c9566be4cd0f74e3618265550704c62a5556912d
neo315
force-pushed
the
export-D16832632
branch
from
c867a57
to
f712ad5
Compare
|
This pull request has been merged in d91aae9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff save one additional sub-modules for best model
Differential Revision: D16832632