This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
EASY [PyText] Fix gen-default-config with Model param #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…ch#917) Summary: Pull Request resolved: facebookresearch#917 gen-default-config fails on Model classes because it wrongly matches base class `torch.nn.modules.module.Module`, which is a lot of different components. Differential Revision: D16846864 fbshipit-source-id: fa6afafbfaf4bc797ea627ff1fcd026714311036
Titousensei
force-pushed
the
export-D16846864
branch
from
41701fd
to
fc44a54
Compare
|
This pull request has been merged in 49ee78d. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
gen-default-config fails on Model classes because it wrongly
matches base class
torch.nn.modules.module.Module, which is a lot ofdifferent components.
Differential Revision: D16846864