This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
use create_module to create CharacterEmbedding
#920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Using `create_module`, instead of initializing directly, enables the module to be loaded / saved. Differential Revision: D16906014 fbshipit-source-id: f1ff4cf01fcd94bf485fe7611d560dbacc48c712
facebook-github-bot
added
the
CLA Signed
|
This pull request has been merged in 2db0cc9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Using
create_module, instead of initializing directly, enables the module to be loaded / saved.Differential Revision: D16906014