This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
nicer gen_config_impl #944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Sep 3, 2019
Summary: Pull Request resolved: facebookresearch#944 nicer internal API for gen_config_impl Differential Revision: D17123234 fbshipit-source-id: dc23e2b55be077cb06e5b56508d9f43b66719185
Titousensei
force-pushed
the
export-D17123234
branch
2 times, most recently
from
fdf5ce1
to
dfe773e
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Sep 9, 2019
Summary: Pull Request resolved: facebookresearch#944 nicer internal API for gen_config_impl. You can now call gen_config_impl() with args and kwargs, which is a better syntax than string when calling from python. Since python parameter names can't contain ".", you still need to use string in this case. For example, cfg = gen_config_impl("LMTask", field_names=["text"]) cfg = gen_config_impl("LMTask", "decoder.embed_dim=10") Differential Revision: D17123234 fbshipit-source-id: db8dc572da5dfba42adde1bb2b66037a84a07414
Titousensei
force-pushed
the
export-D17123234
branch
from
dfe773e
to
e3178e7
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Sep 13, 2019
Summary: Pull Request resolved: facebookresearch#944 nicer internal API for gen_config_impl. You can now call gen_config_impl() with args and kwargs, which is a better syntax than string when calling from python. Since python parameter names can't contain ".", you still need to use string in this case. For example, cfg = gen_config_impl("LMTask", field_names=["text"]) cfg = gen_config_impl("LMTask", "decoder.embed_dim=10") Differential Revision: D17123234 fbshipit-source-id: 0906ae089bd77476cabb623893816df737fba65e
Titousensei
force-pushed
the
export-D17123234
branch
from
e3178e7
to
ffc0b74
Compare
Titousensei
added a commit
to Titousensei/pytext
that referenced
this pull request
Sep 16, 2019
Summary: Pull Request resolved: facebookresearch#944 nicer internal API for gen_config_impl. You can now call gen_config_impl() with args and kwargs, which is a better syntax than string when calling from python. Since python parameter names can't contain ".", you still need to use string in this case. For example, cfg = gen_config_impl("LMTask", field_names=["text"]) cfg = gen_config_impl("LMTask", "decoder.embed_dim=10") Differential Revision: D17123234 fbshipit-source-id: 8c98bce557f3abfe0226b390b226c06cf6636c03
Titousensei
force-pushed
the
export-D17123234
branch
from
ffc0b74
to
c1a2c59
Compare
Summary: Pull Request resolved: facebookresearch#944 nicer internal API for gen_config_impl. You can now call gen_config_impl() with args and kwargs, which is a better syntax than string when calling from python. Since python parameter names can't contain ".", you still need to use string in this case. For example, cfg = gen_config_impl("LMTask", field_names=["text"]) cfg = gen_config_impl("LMTask", "decoder.embed_dim=10") Reviewed By: borguz Differential Revision: D17123234 fbshipit-source-id: a7957746f6e58397c5dde01f6fe2fd9f5a7a8a97
Titousensei
force-pushed
the
export-D17123234
branch
from
c1a2c59
to
480b006
Compare
|
This pull request has been merged in 4de4840. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: nicer internal API for gen_config_impl
Differential Revision: D17123234