This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
add use_config_from_snapshot option(load config from snapshot or current task) #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…ent task) (facebookresearch#970) Summary: Pull Request resolved: facebookresearch#970 Problem: Currently when we call load() from a snapshot, it will construct task with the config saved in the snapshot. However, sometimes, we want to overwrite the config by current task's config Solution: add "use_config_from_snapshot" to PyTextConfig. By default, it use the config saved in snapshot. If we set use_config_from_snapshot=false, it will overwrite the config by current task's config Differential Revision: D17299252 fbshipit-source-id: 57f869d2f1484e1e2bc8c018cb42b37e53a7433f
hudeven
force-pushed
the
export-D17299252
branch
from
e389f14
to
4f43cab
Compare
|
This pull request has been merged in b075241. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Problem:
Currently when we call load() from a snapshot, it will construct task with the config saved in the snapshot. However, sometimes, we want to overwrite the config by current task's config
Solution:
add "use_config_from_snapshot" to PyTextConfig. By default, it use the config saved in snapshot. If we set use_config_from_snapshot=false, it will overwrite the config by current task's config
Differential Revision: D17299252