This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix MultipleData by making tensorizers able to initialize from multiple data sources #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: facebookresearch#953 Add data object that allows combining multiple data types during training and evaluation. Useful when training data is split across different files/partitions, and user wants to explore different combinations Reviewed By: borguz Differential Revision: D17143117 fbshipit-source-id: 881e8288359658826600408b72cf3e6887089630
…le data sources (facebookresearch#972) Summary: Pull Request resolved: facebookresearch#972 For the newly added Data that could read from multiple data sources, there are issues when initializing tensorizers, tensorizers will only be initialized with the last data source, this diff makes tensorizers with vocab able to initiate from multiple data sources by introducing a new parameter in tensorizer initialize. When from_scratch is set to False for Data, it allows tensorizer to accumulate vocab from multiple data sources. I modified each tensorizer accordingly depending on its implementation, the basic change is to not create a new vocab builder when from_scratch is False. Reviewed By: rutyrinott Differential Revision: D17301822 fbshipit-source-id: 041d0bc6aeff5e0ff690f6d43df416d898357f57
liaimi
force-pushed
the
export-D17301822
branch
from
70a1d3b
to
01594fd
Compare
|
This pull request has been merged in 1e4dd71. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: For the newly added Data that could read from multiple data sources, there are issues when initializing tensorizers, tensorizers will only be initialized with the last data source, this diff makes tensorizers with vocab able to initiate from multiple data sources.
Differential Revision: D17301822