Skip to content

Commit

Permalink
Remove unused-but-set variables in vision/fair/pytorch3d/pytorch3d/cs…
Browse files Browse the repository at this point in the history
…rc/pulsar/include/renderer.render.device.h +1

Summary:
This diff removes a variable that was set, but which was not used.

LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.

Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.

For questions/comments, contact r-barnes.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: bottler

Differential Revision: D56886956

fbshipit-source-id: 0c515ed98b812b1c106a59e19ec90751ce32e8c0
  • Loading branch information
r-barnes authored and facebook-github-bot committed May 2, 2024
1 parent 47d5dc8 commit aec76bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pytorch3d/csrc/pulsar/include/renderer.render.device.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ GLOBAL void render(
/** Whether loading of balls is completed. */
SHARED bool loading_done;
/** The number of balls loaded overall (just for statistics). */
SHARED int n_balls_loaded;
[[maybe_unused]] SHARED int n_balls_loaded;
/** The area this thread block covers. */
SHARED IntersectInfo block_area;
if (thread_block.thread_rank() == 0) {
Expand Down

0 comments on commit aec76bb

Please sign in to comment.