Skip to content

Commit

Permalink
Fixing bug in rasterizer.py caused by duplicate line (#1421)
Browse files Browse the repository at this point in the history
Summary:
The file [rasterizer.py](https://github.com/facebookresearch/pytorch3d/blob/de3a474d2b9e0f5d4a77c82106a4a8e7853a4e07/pytorch3d/renderer/mesh/rasterizer.py#L201) contains a duplicate line before the check if the projection_transform exists. This causes an exception in the case that a projection transform matrix is already provided. The corresponding lines should be (and are already) in the else case of the if-statement.

Removing these lines fixes the bug and produces the desired behavior.

Pull Request resolved: #1421

Reviewed By: shapovalov

Differential Revision: D42450999

Pulled By: bottler

fbshipit-source-id: f7464e87ec9ff8768455656324b0b008132c8a54
  • Loading branch information
myla authored and facebook-github-bot committed Jan 19, 2023
1 parent dcced4f commit b95535c
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pytorch3d/renderer/mesh/rasterizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,6 @@ def transform(self, meshes_world, **kwargs) -> torch.Tensor:
verts_view = cameras.get_world_to_view_transform(**kwargs).transform_points(
verts_world, eps=eps
)
# Call transform_points instead of explicitly composing transforms to handle
# the case, where camera class does not have a projection matrix form.
verts_proj = cameras.transform_points(verts_world, eps=eps)
to_ndc_transform = cameras.get_ndc_camera_transform(**kwargs)
projection_transform = try_get_projection_transform(cameras, kwargs)
if projection_transform is not None:
Expand Down

0 comments on commit b95535c

Please sign in to comment.