Update oss Pyre configuration to preemptively guard again upcoming semantic changes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mantic changes Summary: Pyre is going to have a semantic change in its configuration: D35695552. Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups. The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade. Differential Revision: D35724336 fbshipit-source-id: e29dd5ebe0cb1ced2c7d248709e50e82eb415172
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35724336 |
grievejia
added a commit
to grievejia/torchx
that referenced
this pull request
Apr 18, 2022
…mantic changes (pytorch#294) Summary: X-link: facebookresearch/fbpcp#294 X-link: facebookresearch/recipes#19 Pyre is going to have a semantic change in its configuration: D35695552. Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups. The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade. Reviewed By: stroxler Differential Revision: D35724336 fbshipit-source-id: d94f10d68589b1c176e0e8cf7df87ba3f2db9ef2
facebook-github-bot
pushed a commit
to facebookresearch/fbpcp
that referenced
this pull request
Apr 18, 2022
…mantic changes (#463) Summary: X-link: pytorch/torchx#463 Pull Request resolved: #294 X-link: facebookresearch/recipes#19 Pyre is going to have a semantic change in its configuration: D35695552. Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups. The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade. Reviewed By: stroxler Differential Revision: D35724336 fbshipit-source-id: b8156b9d3b5e5c7675b268d676e58c22be1c868e
facebook-github-bot
pushed a commit
to pytorch/torchx
that referenced
this pull request
Apr 18, 2022
…mantic changes (#463) Summary: Pull Request resolved: #463 X-link: facebookresearch/fbpcp#294 X-link: facebookresearch/recipes#19 Pyre is going to have a semantic change in its configuration: D35695552. Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups. The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade. Reviewed By: stroxler Differential Revision: D35724336 fbshipit-source-id: b8156b9d3b5e5c7675b268d676e58c22be1c868e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pyre is going to have a semantic change in its configuration: D35695552.
Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups.
The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade.
Differential Revision: D35724336