More explicit gradient state interface #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Can we also rename the variable from Personally, in the context of a backwards pass, I feel that |
|
Thanks for bringing this up! I agree that Here's my proposal for names: export interface GradContext {
forward_inputs: [Tensor, ...ArgType[]]
forward_output: Tensor
backward_input: Tensor // the associated gradient of forward_output
backward_output_index: number // index of the associated forward input to be differentiated
} |
bwasti
approved these changes
Nov 3, 2022
| @@ -16,7 +16,7 @@ export function relu(tensor: Tensor): Tensor { | |||
| return tensor.maximum(scalar(0)) | |||
| } | |||
|
|
|||
| export function leakyRelu(tensor: Tensor, negative_slope: number): Tensor { | |||
| export function leakyRelu(tensor: Tensor, negative_slope = 1e-3): Tensor { | |||
There was a problem hiding this comment.
fine to sneak this in, but can you annotate with the type? negative_slope: number = 1e-3
There was a problem hiding this comment.
bun format removes the type annotation when the arg has a default
There was a problem hiding this comment.
:o @cryptodeal is that expected?
|
Here's an updated diagram with the new names:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear naming is subjective, but tried to be more explicit.