Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homography] Use kornia lib properly for perspective transform #258

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[homography] Use kornia lib properly for perspective transform #258

merged 1 commit into from
Jul 27, 2022

Conversation

ddetone
Copy link
Contributor

@ddetone ddetone commented Jul 21, 2022

Also reduces the default training dataset size, lowering the "time to fun" :)

Motivation and Context

Gives proper attribution to kornia team's hard work, makes the easyaug.py file more clean and smaller.

How Has This Been Tested

python homography_example.py

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2022
@mhmukadam mhmukadam added the refactor Refactor library components label Jul 21, 2022
mhmukadam referenced this pull request Jul 21, 2022
@fantaosha @ddetone
@joeaortiz @luisenp
Homography example (#242)
982c250 
* add homography files

* fixed some minor bugs

* No bugs for homography_estimation.py

* isorted homography_estimation.py

* added copyright notice

* removed some comments

* added some comments describing the fns

* Moved third_party code to a separate folder.

* Updated README with homography dependencies.

* moved layer init to top, fixed visualisation bug

- removed tensorboard loggin
- put theseus layer init outside of loop
- fixed bug with visualisation using state history

* Changed viz directory.

* added description in examples readme

Co-authored-by: Daniel DeTone <4764838+ddetone@users.noreply.github.com>
Co-authored-by: Joseph Ortiz <20665119+joeaortiz@users.noreply.github.com>
Co-authored-by: Luis Pineda <luisen.p@gmail.com>
@ddetone ddetone merged commit 991c371 into main Jul 27, 2022
@ddetone ddetone deleted the homography_update branch July 27, 2022 16:43
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@ddetone
[homography] Use kornia lib properly for perspective transform, reduc…
f0aba85 
…e default training dataset size (facebookresearch#258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@ddetone ddetone

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ddetone @mhmukadam @facebook-github-bot