Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed SDF constructor to accept more convenient data types. #260

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Changed SDF constructor to accept more convenient data types. #260

merged 2 commits into from
Jul 28, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jul 27, 2022

No description provided.

@luisenp luisenp added the enhancement New feature or request label Jul 27, 2022
@luisenp luisenp requested a review from mhmukadam July 27, 2022 18:02
@luisenp luisenp self-assigned this Jul 27, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 27, 2022
mhmukadam
mhmukadam approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! test_eff_obj_contact.py is failing py37/38 CI.

@luisenp luisenp mentioned this pull request Jul 28, 2022
Merged
@luisenp luisenp merged commit eef28d9 into main Jul 28, 2022
@luisenp luisenp deleted the lep.sdf_easier_constructor branch July 28, 2022 15:42
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Changed SDF constructor to accept more convenient data types. (facebo…
d31830d 
…okresearch#260)

* Changed SDF constructor to accept more convenient data types.

* Fixed broken test and added missing copyright headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisenp @mhmukadam @facebook-github-bot