Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme and bump version #309

Merged
merged 2 commits into from
Sep 28, 2022
Merged

update readme and bump version #309

merged 2 commits into from
Sep 28, 2022

Conversation

mhmukadam
Copy link
Member

No description provided.

@mhmukadam mhmukadam added the documentation Improvements or additions to documentation label Sep 27, 2022
@mhmukadam mhmukadam self-assigned this Sep 27, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 27, 2022
luisenp
luisenp approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you mind changing RMSProp for Adam in the code snippet? It's weird to me that I left it as RMSProp, feels outdated. I'll change in the paper also.

@mhmukadam mhmukadam merged commit 0fa526b into main Sep 28, 2022
@mhmukadam mhmukadam deleted the mhm.readme branch September 28, 2022 14:11
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@mhmukadam
update readme and bump version (facebookresearch#309)
f0da178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp luisenp approved these changes

@fantaosha fantaosha Awaiting requested review from fantaosha

Assignees

@mhmukadam mhmukadam

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhmukadam @luisenp @facebook-github-bot