Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved all unit tests to a separate folder #352

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Moved all unit tests to a separate folder #352

merged 1 commit into from
Nov 4, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Nov 4, 2022

  • Reduces bloat in the namespace theseus and the installed package
  • Makes it easier to test different installed versions of Theseus

@luisenp luisenp added the refactor Refactor library components label Nov 4, 2022
@luisenp luisenp self-assigned this Nov 4, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2022
@luisenp luisenp changed the base branch from main to lep.better_warning_lie_checks November 4, 2022 20:55
mhmukadam
mhmukadam approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating this. Much cleaner tests now!

@mhmukadam
Copy link
Member

Cuda CI needs fixing. In fact, maybe the separate command for just test_theseus_layer.py could be combined with the rest of the tests folder?

@luisenp
Copy link
Contributor Author

luisenp commented Nov 4, 2022

Cuda CI needs fixing. In fact, maybe the separate command for just test_theseus_layer.py could be combined with the rest of the tests folder?

That separation is deliberate so that we only run CUDA-specific tests (end-to-end + marked as cudaext). We are not currently running the full suite of tests in GPU.

Base automatically changed from lep.better_warning_lie_checks to main November 4, 2022 21:25
@luisenp luisenp merged commit 65dc682 into main Nov 4, 2022
@luisenp luisenp deleted the lep.move_tests branch November 4, 2022 22:22
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Moved all unit tests to a separate folder. (facebookresearch#352)
6454995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisenp @mhmukadam @facebook-github-bot