Cleaned up sparse solvers code #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
maurimo
approved these changes
Nov 29, 2022
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
* Created utility function to sample sparse matrix tensors. * Renamed some incorrectly capitalized variables. * Added missing type hints to sparse linear solvers code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some clean up of the code in
optimizer/autogradandoptimizer/linear, including adding type hints. Most of the changes are variable names and type hints, except for addingnew_emptyin a couple of places, and adding new function for samping sparse matrices.There is some duplicated code in
backwardpasses that should be relatively easy to fix, but I'd prefer doing that in a separate smaller PR to avoid introducing bugs.Closes #326