Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to automatically pick number of LUCuda contexts #390

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Dec 1, 2022

No description provided.

@luisenp luisenp added the enhancement New feature or request label Dec 1, 2022
@luisenp luisenp requested a review from maurimo December 1, 2022 17:00
@luisenp luisenp self-assigned this Dec 1, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2022
@luisenp luisenp force-pushed the lep.auto_pick_num_lucuda_contexts branch from cea6676 to bfb5cac Compare December 1, 2022 20:21
Base automatically changed from lep.reject_logic_fix to main December 1, 2022 21:13
Copy link
Contributor

@maurimo maurimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a nicer workaround - would eventually love to nuke the LUCuda contexts workaround one day however!

@luisenp luisenp force-pushed the lep.auto_pick_num_lucuda_contexts branch from d5e545d to a397f85 Compare December 2, 2022 18:39
@luisenp luisenp merged commit 15c1f70 into main Dec 2, 2022
@luisenp luisenp deleted the lep.auto_pick_num_lucuda_contexts branch December 2, 2022 19:03
@@ -416,6 +416,29 @@ def _optimize_loop(
] = NonlinearOptimizerStatus.MAX_ITERATIONS
return iters_done

# Returns how many iterations to do with and without autograd
def _split_backward_iters(self, **kwargs) -> Tuple[int, int]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, separating this out improved readability.

Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on auto setting the context size, LGTM!

suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
…earch#390)

* Added logic to automatically pick number of solver contexts for LUCuda.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants