-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code to automatically pick number of LUCuda contexts #390
Conversation
cea6676
to
bfb5cac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a nicer workaround - would eventually love to nuke the LUCuda contexts workaround one day however!
d5e545d
to
a397f85
Compare
@@ -416,6 +416,29 @@ def _optimize_loop( | |||
] = NonlinearOptimizerStatus.MAX_ITERATIONS | |||
return iters_done | |||
|
|||
# Returns how many iterations to do with and without autograd | |||
def _split_backward_iters(self, **kwargs) -> Tuple[int, int]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, separating this out improved readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on auto setting the context size, LGTM!
…earch#390) * Added logic to automatically pick number of solver contexts for LUCuda.
No description provided.