Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a timer util that adapts to a torch.device. #399

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add a timer util that adapts to a torch.device. #399

merged 2 commits into from
Dec 13, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Dec 8, 2022 •
edited
Loading

Removes boilerplate. Can be used as

from thesus.utils import Timer

with Timer("cuda:0") as timer:
   some_stuff
print(timer.elapsed_time)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 8, 2022
fantaosha
fantaosha approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luisenp luisenp merged commit 963178d into main Dec 13, 2022
@luisenp luisenp deleted the lep.timer_util branch December 13, 2022 14:17
@mhmukadam
Copy link
Member

mhmukadam commented Jan 2, 2023 •
edited
Loading

Nice, might want to add the usage as comments above the class code. LGTM!

@luisenp
Copy link
Contributor Author

luisenp commented Jan 12, 2023 

from thesus.utils import Timer

with Timer("cuda:0") as timer:
   some_stuff
print(timer.elapsed_time)

Added in 556d6ba

suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Add a timer util that adapts to a torch.device. (facebookresearch#399)
73b87a6 
* Add a timer util that adapts to a torch.device.

* Fix Timer so it returns self on enter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantaosha fantaosha fantaosha approved these changes

@mhmukadam mhmukadam Awaiting requested review from mhmukadam

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot