Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nox dependency #436

Merged
merged 9 commits into from
Jan 19, 2023
Merged

Remove nox dependency #436

merged 9 commits into from
Jan 19, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 18, 2023

This standardizes local and CI test suite.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2023
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 310 CI is failing (looks like a mypy cast thing).

@luisenp luisenp force-pushed the lep.remove_nox branch 2 times, most recently from 8c7819a to 378c0f2 Compare January 18, 2023 23:41
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@luisenp luisenp merged commit be316e5 into main Jan 19, 2023
@luisenp luisenp deleted the lep.remove_nox branch January 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants