-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nox dependency #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 18, 2023
luisenp
force-pushed
the
lep.remove_nox
branch
from
January 18, 2023 19:06
0488d2e
to
cf7a95a
Compare
luisenp
force-pushed
the
lep.remove_nox
branch
from
January 18, 2023 19:06
cf7a95a
to
3d09777
Compare
luisenp
force-pushed
the
lep.remove_nox
branch
from
January 18, 2023 19:25
7ce55ea
to
f7805fa
Compare
mhmukadam
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 310 CI is failing (looks like a mypy cast thing).
luisenp
force-pushed
the
lep.remove_nox
branch
from
January 18, 2023 22:40
1a52b40
to
48e913e
Compare
mhmukadam
reviewed
Jan 18, 2023
mhmukadam
approved these changes
Jan 18, 2023
luisenp
force-pushed
the
lep.remove_nox
branch
2 times, most recently
from
January 18, 2023 23:41
8c7819a
to
378c0f2
Compare
luisenp
force-pushed
the
lep.remove_nox
branch
from
January 18, 2023 23:50
378c0f2
to
03f3670
Compare
mhmukadam
reviewed
Jan 19, 2023
mhmukadam
reviewed
Jan 19, 2023
mhmukadam
approved these changes
Jan 19, 2023
luisenp
force-pushed
the
lep.remove_nox
branch
from
January 19, 2023 13:42
a80c80a
to
a8a8910
Compare
mhmukadam
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes local and CI test suite.