Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some clean up of Lie Groups code #449

Merged
merged 5 commits into from
Feb 20, 2023
Merged

Some clean up of Lie Groups code #449

merged 5 commits into from
Feb 20, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 26, 2023

No description provided.

@luisenp luisenp self-assigned this Jan 26, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2023
mhmukadam
mhmukadam approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work brining consistency for Jacobian factory and consolidating function generation.

fantaosha
fantaosha approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luisenp luisenp merged commit 3c31e9f into main Feb 20, 2023
@luisenp luisenp deleted the lep.lie_cleanup branch February 20, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

@fantaosha fantaosha fantaosha approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot