Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test to check the PGO loss values automatically #456

Merged
merged 8 commits into from
Feb 24, 2023
Merged

Add a unit test to check the PGO loss values automatically #456

merged 8 commits into from
Feb 24, 2023

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Feb 3, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2023
fantaosha
fantaosha approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@fantaosha fantaosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe set BaSpaCho as the default solver.

theseus/utils/examples/pose_graph/dataset.py Show resolved Hide resolved
examples/configs/pose_graph/pose_graph_synthetic.yaml Show resolved Hide resolved
tests/test_pgo_benchmark.py Show resolved Hide resolved
@mhmukadam mhmukadam marked this pull request as ready for review February 23, 2023 06:33
mhmukadam
mhmukadam approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this is super useful! Feel free to merge once you add the baspacho block.

@luisenp luisenp merged commit f03c5aa into main Feb 24, 2023
@luisenp luisenp deleted the lep.full_pgo_test branch February 24, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantaosha fantaosha fantaosha approved these changes

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@luisenp @mhmukadam @fantaosha @facebook-github-bot