Minor fixes to motion planner code. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mhmukadam
reviewed
Mar 6, 2023
| @@ -115,7 +115,8 @@ def __init__( | |||
| # ------------------------------- Cost weights ------------------------------ # | |||
| # --------------------------------------------------------------------------- # | |||
| # For the GP cost functions, we create a single GPCost weight | |||
| gp_cost_weight = th.eb.GPCostWeight(torch.tensor(Qc_inv, dtype=dtype), dt) | |||
| qc_inv_tensor = torch.as_tensor(Qc_inv, dtype=dtype) | |||
| gp_cost_weight = th.eb.GPCostWeight(qc_inv_tensor.to(dtype=dtype), dt) | |||
There was a problem hiding this comment.
You probably don't need the .to since the previous line already sets the dtype, right?
There was a problem hiding this comment.
Oh also do you need to handle device here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.