Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename check functions #516

Merged
merged 2 commits into from
May 25, 2023
Merged

Rename check functions #516

merged 2 commits into from
May 25, 2023

Conversation

fantaosha
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2023
luisenp
luisenp approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@luisenp luisenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from taoshaf.multi_batch_gradient_ops to main May 11, 2023 14:42
@fantaosha fantaosha force-pushed the taoshaf.rename_check_functions branch from 1dc15d5 to f49ed3b Compare May 11, 2023 14:47
@fantaosha fantaosha force-pushed the taoshaf.rename_check_functions branch from f49ed3b to 9176a40 Compare May 25, 2023 15:21
@luisenp luisenp merged commit 809d499 into main May 25, 2023
1 check passed
@luisenp luisenp deleted the taoshaf.rename_check_functions branch May 25, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisenp luisenp luisenp approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fantaosha @luisenp @facebook-github-bot